Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noti: 3.1.0 -> 3.2.0 #66680

Merged
merged 1 commit into from
Aug 16, 2019
Merged

noti: 3.1.0 -> 3.2.0 #66680

merged 1 commit into from
Aug 16, 2019
+12 −12

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @stites

Sorry, something went wrong.

jonringer
jonringer approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (minor suggestions)
binaries seem to work
leaf package

pkgs/tools/misc/noti/default.nix Outdated
name = "noti-${version}";
version = "3.1.0";
let
isDarwin = stdenv.buildPlatform.isDarwin;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isDarwin = stdenv.buildPlatform.isDarwin;
isDarwin = stdenv.isDarwin;

I would also just inline it as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and thanks for the review!

@peterhoeg
noti: 3.1.0 -> 3.2.0

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
8a694c6
@peterhoeg peterhoeg merged commit 14f5528 into NixOS:master Aug 16, 2019
@peterhoeg peterhoeg deleted the u/noti branch August 16, 2019 02:07
@peterhoeg peterhoeg restored the u/noti branch August 16, 2019 11:06
@peterhoeg peterhoeg deleted the u/noti branch August 19, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @jonringer