Clean up WPT TestExpectations for CSS animations and transitions #18458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1748116
branch
from
6d68f51
to
f0ca751
Compare
external/wpt/css/css-animations/Element-getAnimations.tentative.html external/wpt/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html (turned on and baselined, code appears to have been fixed earlier) external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html (now has same behavior reargless of when in frame the test is started) external/wpt/css/css-transitions/properties-value-* (fix duration to allow for CPU stress and add RAF before checking event handlers are called, using guideline in https://web-platform-tests.org/writing-tests/testharness-api.html#timeouts-in-tests "Note that timeouts generally need to be a few seconds long in order to produce stable results in all test environments.") external/wpt/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html (marked flaky instead of always-fail, test sometimes passes) REMOVE external/wpt/css/css-transitions/transitions-animatable-properties-01.html (old and flaky duplicate of properties-value-001.html) (serial timeouts add to close to 60s, causing harness timeout in CI) Bug: 849975, 849927, 922970, 825262, 332189, 626703, Change-Id: Id03994b3017ac72858dca00ee71d9b89dacbd3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748116 Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Auto-Submit: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#687422}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1748116
branch
from
f0ca751
to
dd929cb
Compare
|
The flakiness is pre-existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external/wpt/css/css-animations/Element-getAnimations.tentative.html
external/wpt/css/css-transitions/AnimationEffect-getComputedTiming.tentative.html
(turned on and baselined, code appears to have been fixed earlier)
external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html
(now has same behavior reargless of when in frame the test is started)
external/wpt/css/css-transitions/properties-value-*
(fix duration to allow for CPU stress and add RAF before checking event
handlers are called, using guideline in
https://web-platform-tests.org/writing-tests/testharness-api.html#timeouts-in-tests
"Note that timeouts generally need to be a few seconds long
in order to produce stable results in all test environments.")
external/wpt/css/css-transitions/no-transition-from-ua-to-blocking-stylesheet.html
(marked flaky instead of always-fail, test sometimes passes)
REMOVE external/wpt/css/css-transitions/transitions-animatable-properties-01.html
(old and flaky duplicate of properties-value-001.html)
(serial timeouts add to close to 60s, causing harness timeout in CI)
Bug: 849975, 849927, 922970, 825262, 332189, 626703,
Change-Id: Id03994b3017ac72858dca00ee71d9b89dacbd3c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748116
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687422}