Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartgithg: 18.2.9 -> 19.1.1 #66692

Merged
merged 1 commit into from Aug 17, 2019
Merged

smartgithg: 18.2.9 -> 19.1.1 #66692

merged 1 commit into from Aug 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 15, 2019 •
edited

Motivation for this change

noticed it was broken (bad sha) while reviewing another package.

bumped version while at it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jraygauthier

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66692
1 package were build:
smartgithg

@jonringer jonringer changed the title smart: 18.2.9 -> 19.1.1 smartgithg: 18.2.9 -> 19.1.1 Aug 15, 2019
cristinecula
cristinecula approved these changes Aug 16, 2019
View reviewed changes
Copy link

@cristinecula cristinecula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works!

@mmahut
Copy link
Member

mmahut commented Aug 16, 2019

Looks like their sha256 keeps changing upon download.

  wanted: sha256:0hl0nypvkj1bnqn6352a0szhzhr6zd7b4p9f5wyaxa4dw565461p
  got:    sha256:0i0dvyy9d63f4hk8czlyk83ai0ywhqp7wbdkq3s87l7irwgs42jy

@jraygauthier
Copy link
Member

Couldn't it be that the expected sha256 is simply incorrect? I obtain the exact same sha as @mmahut:

$ nix-prefetch-url https://www.syntevo.com/downloads/smartgit/smartgit-linux-19_1_1.tar.gz
[47.7 MiB DL]
path is '/nix/store/ifbgm8klj9lzccg59n5pym0dicki5xzn-smartgit-linux-19_1_1.tar.gz'
0i0dvyy9d63f4hk8czlyk83ai0ywhqp7wbdkq3s87l7irwgs42jy

@jonringer
Copy link
Contributor Author

looks like i fixed the sha to get it to build, then bumped the version, then forgot to update the sha again. My bad :)

@jonringer
Copy link
Contributor Author

jonringer commented Aug 16, 2019 •
edited

@GrahamcOfBorg build smartgithg

oh, it's unfree :(. Makes sense

jraygauthier
jraygauthier approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, sha256 now ok and downloads. Did not test the application however.

aanderse
aanderse approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything is sorted out, according to comments and running nix-review on this PR. LGTM 👍
Thanks everyone! 🎉

@aanderse aanderse merged commit 7a71220 into NixOS:master Aug 17, 2019
@jonringer jonringer deleted the bump-smartgit branch August 17, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinecula cristinecula cristinecula approved these changes

@jraygauthier jraygauthier jraygauthier approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @mmahut @jraygauthier @cristinecula @aanderse