Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skaffold: 0.30.0 -> 0.35.0 #66691

Merged
merged 1 commit into from Aug 16, 2019
Merged

skaffold: 0.30.0 -> 0.35.0 #66691

merged 1 commit into from Aug 16, 2019

Conversation

aespinosa
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary works
leaf package

[2 built, 4 copied (437.9 MiB), 109.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66691
1 package were build:
skaffold

@mmahut
Copy link
Member

mmahut commented Aug 16, 2019

@GrahamcOfBorg build skaffold

@mmahut mmahut merged commit 9764865 into NixOS:master Aug 16, 2019
@risicle
Copy link
Contributor

risicle commented Aug 16, 2019

nix-review passes on macos 10.13, binary works.

@aespinosa aespinosa deleted the skaffold branch August 17, 2019 18:34
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/53

@worldofpeace worldofpeace mentioned this pull request Aug 19, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aespinosa @mmahut @risicle @nixos-discourse @jonringer