Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More features in ApproximateQuantity #2288

Merged
merged 3 commits into from
Aug 17, 2019
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 17, 2019

  • Support for querying the unit.
  • Computation of distance in ulps.
  • Support for signs.
  • Linker fixes.

return representation_ + "(" + std::to_string(ulp_) + ") * " +
quantities::DebugString(unit_);
if (has_trivial_unit()) {
return (negated_ ? "-" : "") + representation_ +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indent; same in the else branch.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Aug 17, 2019
@pleroy pleroy merged commit fe6052d into mockingbirdnest:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants