Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-sizing] Computed min/max width/height #18521

Merged
merged 1 commit into from Aug 20, 2019
Merged

[css-sizing] Computed min/max width/height #18521

merged 1 commit into from Aug 20, 2019

Conversation

ewilligers
Copy link
Contributor

The computed value for the following properties is
as specified, with values computed.

  • min-width
  • min-height
  • max-width
  • max-height

https://drafts.csswg.org/css-sizing-3/#min-size-properties
https://drafts.csswg.org/css-sizing-3/#max-size-properties

@ericwilligers
[css-sizing] Computed min/max width/height
c7d1761 
The computed value for the following properties is
as specified, with <length-percentage> values computed.
- min-width
- min-height
- max-width
- max-height

https://drafts.csswg.org/css-sizing-3/#min-size-properties
https://drafts.csswg.org/css-sizing-3/#max-size-properties
@ewilligers
Copy link
Contributor Author

@BorisChiou please review

BorisChiou
BorisChiou approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@BorisChiou BorisChiou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, I'm not sure what is the expected computed value for min-height/min-width:auto. I tried this and It seems both Chrome and Firefox dump 0px by getComputedStyle().

@ewilligers
Copy link
Contributor Author

auto resolves to 0 in common cases, for compatibility with CSS2:

For min-width/min-height, specifies an automatic minimum size. Unless otherwise defined by the relevant layout module, however, it resolves to a used value of 0. For backwards-compatibility, the resolved value of this keyword is zero for boxes of all [CSS2] display types: block and inline boxes, inline blocks, and all the table layout boxes. It also resolves to zero when no box is generated.

@ewilligers ewilligers merged commit a655237 into web-platform-tests:master Aug 20, 2019
@ewilligers ewilligers deleted the computed-min-max-height-width branch August 20, 2019 00:40
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@ewilligers @natechapin
[css-sizing] Computed min/max width/height (web-platform-tests#18521)
8be8ee0 
The computed value for the following properties is
as specified, with <length-percentage> values computed.
- min-width
- min-height
- max-width
- max-height

https://drafts.csswg.org/css-sizing-3/#min-size-properties
https://drafts.csswg.org/css-sizing-3/#max-size-properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisChiou BorisChiou BorisChiou approved these changes

@litherum litherum Awaiting requested review from litherum

@fantasai fantasai Awaiting requested review from fantasai

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

@tabatkins tabatkins

Labels
css-sizing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ewilligers @BorisChiou @tabatkins @moz-wptsync-bot @ericwilligers