Remove invalid test cases using unitless zero length in math functions #18515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 17, 2019
Spec (*) explicitly disallows unitless zero length in math functions: > Note: Because <number-token>s are always interpreted as <number>s or > <integer>s, "unitless 0" <length>s aren’t supported in math functions. > That is, 'width: calc(0 + 5px);' is invalid, because it’s trying to > add a <number> to a <length>, even though both 'width: 0;' and > 'width: 5px;' are valid. There are some existing WPT test cases violating this, which are removed in this patch. (*) https://drafts.csswg.org/css-values-4/#calc-type-checking Bug: 994359 Change-Id: Iba66c4e425ec24133c7f70bbbeca7a60d59e1883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758734 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688401}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1758734
branch
from
5033be8
to
c27d540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec (*) explicitly disallows unitless zero length in math functions:
There are some existing WPT test cases violating this, which are
removed in this patch.
(*) https://drafts.csswg.org/css-values-4/#calc-type-checking
Bug: 994359
Change-Id: Iba66c4e425ec24133c7f70bbbeca7a60d59e1883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758734
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688401}