pythonPackages.vcard: init at 0.13.0 #66738
Conversation
There was a problem hiding this comment.
If it is used as a library the expresssion needs to be moved under python-modules/. In that case also explicitly list all dependencies as arguments, instead of passing in python3Packages. Currently you are mixing both the package set and dependencies and that should especially be avoided.
Aside from that it looks good.
@FRidh Thank you for reviewing! Can you please check my changes? This is my first Nix package, and I don't even know what constitutes the "package set" and how it differs from the "dependencies". I thought This package is meant to be used both as a command line tool (in fact that's the only way I use it myself), but it's also been made to work as a library. I've tried to make that work, but I'm not sure this is the right way of going about it. The documentation seems to focus on doing either one or the other, not both. Edit: ping? |
RFC 2426. Unfortunately the standard is in part ambiguous and self-contradictory, and it's really hard to find valid examples in the wild – even the examples given in section 7 of the RFC are invalid - they are missing the mandatory |
|
Welp. Moved the changes to a branch, and now I don't seem to be able to recover this PR. New PR |
Motivation for this change
Add vCard validator.
Things done
nix-shell -p nix-review --run "nix-review wip"(Not applicable)./result/bin/)nix path-info -Sbefore and after (before and after building? How to do this if I was not aware of this package before building?))Notify maintainers
cc @l0b0