New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glusterfs: 4.0 -> 6.5 #66736
glusterfs: 4.0 -> 6.5 #66736
Conversation
(I guess I have lost track even of the list of packages I have auto-updated at some point…) Argh, they don't have a convenient changelog. But it does seem nothing breaking has happenned, and the test is nice, a separate thanks for that (I have never actually used GlusterFS in a way that would require noticeably more than what this test checks). |
d7de4bb
to
31bdccd
Compare
@GrahamcOfBorg test glusterfs |
* remove patches (fixed upstream) * python2 -> python3
31bdccd
to
6104ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving; I did not test it, but my concern with the not-yet-landed patch was addressed.
This broke Xen build: https://hydra.nixos.org/build/98992176/nixlog/1/tail
|
Quick googling tells that this incompatability has been introduced in with glusterfs v6. Qemu also had to fix it: https://patchwork.kernel.org/patch/10839611/ |
@markuskowa yes, this patch is at https://xenbits.xen.org/gitweb/?p=qemu-xen.git;a=commit;h=0e3b891fefacc0e49f3c8ffa3a753b69eb7214d2, which is internal qemu which Xen uses for build |
@danbst would you mind opening a PR adding that patch? I am not familiar with Xen. |
unfortunately I'm distant of that as well. But I can try to update Xen |
It was broken during GlusterFs upgrade: NixOS#66736
* xen: 4.8.3 -> 4.8.5, unbreak It was broken during GlusterFs upgrade: #66736
Motivation for this change
GlusterFS is on a really old version. Added a simple nixos test.
Probably needs some testing. Feedback is welcome.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @7c6f434c @nh2