[LayoutNG] Set table-cell borders, and intrinsic-padding via. constraints. #18463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754097
branch
3 times, most recently
from
1f91210
to
3dae6ca
Compare
…ints. As above, this was some previously accumulated debt. It isn't clear if the intrinsic-padding is a good concept yet, but removes some bad layout-box calls. Bug: 993095 Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#687511}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754097
branch
from
3dae6ca
to
6483c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above, this was some previously accumulated debt. It isn't clear if
the intrinsic-padding is a good concept yet, but removes some bad
layout-box calls.
Bug: 993095
Change-Id: Idc4e9e67afa2fbd9c84976cb2878b215624298c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754097
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687511}