Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test orbit analysis on real orbits #2284

Merged
merged 18 commits into from
Aug 17, 2019

Conversation

eggrobin
Copy link
Member

And find, and fix, a bug.

astronomy/orbit_analysis_test.cpp Outdated Show resolved Hide resolved
Ephemeris<ICRS>::FixedStepParameters(
SymmetricLinearMultistepIntegrator<QuinlanTremaine1990Order12,
Position<ICRS>>(),
/*step=*/1 * JulianYear))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One year? Really?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.

astronomy/orbit_analysis_test.cpp Outdated Show resolved Hide resolved

SolarSystem<ICRS> earth_1957_;
not_null<std::unique_ptr<Ephemeris<ICRS>>> ephemeris_;
RotatingBody<ICRS> const& earth_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No oblateness?

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no need to know about the properties of the oblateness here.

Sorry, something went wrong.

astronomy/orbit_analysis_test.cpp Show resolved Hide resolved
Property(&OrbitRecurrence::Dᴛₒ, 0),
Property(&OrbitRecurrence::Cᴛₒ, 1)));
EXPECT_THAT(elements.mean_semimajor_axis_interval().midpoint(),
IsNear(42'166 * Kilo(Metre)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these numbers come from some reference document? Can you give references? Same questions everywhere.

Copy link
Member Author

@eggrobin eggrobin Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give references where they do come from some reference document; where they do not, they are just the truncation of whatever the test spat out.

This will be made clearer once we have the new matchers: we can use

IsNear(12'345_⑴ * Kilo(Metre))

for the change-detector tests, and

AbsoluteErrorFrom(12'345 * Kilo(Metre), IsNear(3.2_⑴ * Kilo(Metre)))

where we have nominal values.

@pleroy pleroy added the LGTM label Aug 17, 2019
@eggrobin eggrobin merged commit bfd6c8a into mockingbirdnest:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants