Androidenv fixes #66747
Merged
Androidenv fixes #66747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was originally intended but left unfinished, as indicated by the unused variables 'args' and 'androidSdkArgNames'.
This system type was previously broken but is now fixed. Add it here to showcase the common task of launching a fully-fledged Android system with an included app store.
This greatly improves readability by shortening some of the overlong lines.
Removes some visual clutter.
erikarvstedt
force-pushed
the
androidenv-fixes
branch
from
52a8242
to
1b81302
Compare
| @@ -1,24 +1,21 @@ | |||
| { composeAndroidPackages, stdenv }: | |||
| { name, app ? null | |||
| , platformVersion ? "16", abiVersion ? "armeabi-v7a", systemImageType ? "default", useGoogleAPIs ? false | |||
There was a problem hiding this comment.
Does useGoogleAPIs not have an effect elsewhere?
There was a problem hiding this comment.
No, it's unused. The original author forgot to pass it to composeAndroidPackages.
matthewbauer
approved these changes
Aug 19, 2019
svanderburg
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commit messages.
Use this to test commit
androidenv: Fix deployment of google_apis* system images:cc @svanderburg
Things done
All of them.