Load Ahem as web font in vars-font-shorthand-001.html #18485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukeZielinski this test appears to predate your Ahem rewrite. Can you check why this test was missed and if there are any more like it? |
|
Ok, so this test sets a variable to "ahem" and then sets font-family to that variable. Not sure there's any reasonable way to grep for that, and there very well might be more tests like this. I plan to do a final sweep where I update the WPT code to disable installing ahem completely and then see what breaks on CI. That should catch cases like this. |
|
@LukeZielinski can you also review this change? |
foolip
force-pushed
the
foolip/ahem-vars-font-shorthand
branch
from
08fec17
to
57319ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.