Check requested reference space against enabled XR session features #18471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754275
branch
from
cdfbb70
to
5fc3ddc
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754275
branch
from
5fc3ddc
to
47f2780
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754275
branch
from
47f2780
to
1d1dab5
Compare
Currently we only check if the requested reference space is supported by the device before resolving the request. With more detailed consent this is no longer sufficient, we need to also check the underlying feature of the reference space against which features have been enabled. This CL also does some minor refactoring of code related to XRSessionFeature. Bug: 985095 Change-Id: Ibe6ecadbc6ce25c523eb4ee9d8a73560d8580df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754275 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#687912}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1754275
branch
from
1d1dab5
to
c78e545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only check if the requested reference space is supported
by the device before resolving the request. With more detailed consent
this is no longer sufficient, we need to also check the underlying
feature of the reference space against which features have been enabled.
This CL also does some minor refactoring of code related to
XRSessionFeature.
Bug: 985095
Change-Id: Ibe6ecadbc6ce25c523eb4ee9d8a73560d8580df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754275
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#687912}