Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable webxr for the UWP port. #23978

Merged
merged 1 commit into from Aug 17, 2019
Merged

Enable webxr for the UWP port. #23978

merged 1 commit into from Aug 17, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Aug 15, 2019 •
edited by SimonSapin

This avoids a common papercut for the UWP port while our webxr support is still in progress.

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2019
@jdm
Copy link
Member Author

jdm commented Aug 15, 2019

r? @Manishearth

@highfive highfive assigned Manishearth and unassigned emilio Aug 15, 2019
@Manishearth
Copy link
Member

@bors-servo r+

./mach package does have code for merging in additional prefs, fwiw

@bors-servo
Copy link
Contributor

📌 Commit a94d4b2 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 15, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit a94d4b2 with merge 9a0c02c...

bors-servo pushed a commit that referenced this pull request Aug 16, 2019
Auto merge of #23978 - servo:jdm-patch-49, r=Manishearth
9a0c02c 
Enable webxr for the UWP port.

This avoids a common papercut for the UWP port while our webxr support is still in progress.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23978)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 9a0c02c to master...

@bors-servo bors-servo merged commit a94d4b2 into master Aug 17, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 17, 2019
This was referenced Aug 17, 2019
Merged
Merged
@SimonSapin SimonSapin deleted the jdm-patch-49 branch September 30, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @Manishearth @bors-servo @emilio @highfive