[LayoutNG] Add the "simplified" layout pass. #16738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 8, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1590237
branch
3 times, most recently
from
9442df8
to
f20f064
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1590237
branch
4 times, most recently
from
b3534c2
to
f4dacaf
Compare
This introduces the simplified layout algorithm. This is triggered when - An OOF descendant has its constraints changed. - The block-size of a fragment changes in size. There are several nuanced details with this algorithm. E.g. determining the correct static position for an OOF descendant. Bug: 635619 Change-Id: Iba4c4b82edf873fa4cad9ba28e9fa3849a4a8e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590237 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#659745}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1590237
branch
from
f4dacaf
to
a5e4924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the simplified layout algorithm. This is triggered when
There are several nuanced details with this algorithm. E.g. determining
the correct static position for an OOF descendant.
Bug: 635619
Change-Id: Iba4c4b82edf873fa4cad9ba28e9fa3849a4a8e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590237
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659745}