Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to download WebDriver on the new MicrosoftEdge #16691

Merged
merged 5 commits into from May 14, 2019

Conversation

loly89
Copy link
Contributor

@loly89 loly89 commented May 6, 2019

Creating another wpt product 'chromiumedge' for the new Microsoft Edge since it's totally different compared to the old one.

The ability to download and install the new MicrosoftEdge browser will be coming soon.
As of now, users will need to download, install MicrosoftEdge insider version and add the installed location to PATH system variable.

loly89 added 2 commits May 6, 2019 12:32
Add the ability to download MSEdgeDriver automatically to test against
the new MicrosoftEdge.
@wpt-pr-bot wpt-pr-bot added infra wpt wptrunner The automated test runner, commonly called through ./wpt run labels May 6, 2019
@gsnedders
Copy link
Member

Do we want this to be chromiumedge or edgechromium? I think I'd rather the latter because then it starts with edge, which is probably more expected. At a quick glance, this otherwise looks good.

@loly89
Copy link
Contributor Author

loly89 commented May 8, 2019

Do we want this to be chromiumedge or edgechromium? I think I'd rather the latter because then it starts with edge, which is probably more expected. At a quick glance, this otherwise looks good.

I've changed the product to be 'edgechromium'. Do you have any other feedback? :)

@lukebjerring
Copy link
Contributor

@Hexcles FYI - might be worth double checking the handling of edgechromium in wpt.fyi

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small issues, but that's all. 🙂

tools/wpt/browser.py Outdated Show resolved Hide resolved
tools/wpt/run.py Show resolved Hide resolved
@gsnedders gsnedders merged commit 70a130f into web-platform-tests:master May 14, 2019
Hexcles added a commit to web-platform-tests/wpt.fyi that referenced this pull request May 27, 2019
Treat it similar to "edge_webdriver" (i.e. consider it as Edge).

The product was added to WPT in
web-platform-tests/wpt#16691 .
Hexcles added a commit to web-platform-tests/wpt.fyi that referenced this pull request May 28, 2019
Treat it similar to "edge_webdriver" (i.e. consider it as Edge).

The product was added to WPT in
web-platform-tests/wpt#16691 .
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
This includes the ability to download MSEdgeDriver automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wpt wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants