pythonPackages.imread: 0.6 -> 0.7.0 #61033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly trivial update of version and hashes, but also explicitly use the right dependencies
|
Is the change from |
|
No, I didn't even realize that it was happening. That's because |
|
@luispedro: exactly |
|
Python packages so far rarely shadowed native dependencies, so this should be fine imho and is commonly used. It also makes overriding dependencies easier. |
|
@Mic92 python-packages.nix is full of "inherit (pkgs) pkgconfig;" https://github.com/NixOS/nixpkgs/search?utf8=✓&q=python-modules+pkgconfig&type= As I understood this was exactly for that reason. |
|
[detached HEAD a3f8a25] python.pkgs.imread: inherit native libs on callsite |
Mic92
added a commit
that referenced
this pull request
May 7, 2019
this avoids potential namespace collisions between python libs and packages from all-packags.nix: #61033 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly trivial update of version and hashes, but also explicitly use the
right dependencies
Motivation for this change
Updates imread to latest version.
Things done
sandboxinnix.confon non-NixOS)- [x] other Linux distributions