Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partitionmanager,kpmcore: 3.3.{0,1} -> 4.1.0 #61077

Closed
wants to merge 6 commits into from
Closed

partitionmanager,kpmcore: 3.3.{0,1} -> 4.1.0 #61077

wants to merge 6 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 7, 2019 •
edited

Motivation for this change

https://stikonas.eu/wordpress/2019/05/02/kde-partition-manager-4-0/

I've had some trouble with the permissions/auth situation,
even running it as root doesn't seem to work?

This may be my environment, but should hold off merging until
someone reports the updated versions are working for them
or I sort out what's going on locally :).

2020:

  • bump further to 4.1.0
  • no longer need to pin to "newer" utillinux, version in-tree is sufficient (newer than the pin anyway)
  • Drop wrapQtAppsHook since qt's mkDerivation is already used
    (not sure the use of both wrapGAppsHook and qt wrapper hook will work properly as-is but double-including seems unhelpful regardless)

Still issues running w/o sudo, not sure what that's about.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peterhoeg and Ma27 May 7, 2019 07:07
@Ma27
Copy link
Member

Ma27 commented May 7, 2019

The change itself seems fine, but partition-manager is stuck during the opening. There's a dialog which tells that all devices are scanned and it's been for ~25min at 0%.

Is this a known problem?

@dtzWill
Copy link
Member Author

dtzWill commented May 7, 2019 via email

@Ma27
Copy link
Member

Ma27 commented Jun 20, 2019

Dunno, looks like this isn't ready yet! :)

Any news here? :)

@jtojnar jtojnar mentioned this pull request Dec 25, 2019
Closed
@dtzWill dtzWill force-pushed the update/partitionmanager-kpmcore-4 branch from d5cd220 to 0c5c6dc Compare February 13, 2020 02:54
@dtzWill dtzWill changed the title partitionmanager,kpmcore: 3.3.{0,1} -> 4.0.0 partitionmanager,kpmcore: 3.3.{0,1} -> 4.1.0 Feb 13, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 27, 2020

Is the current state testable or is this blocked by something else? :)

@Ma27 Ma27 removed their request for review May 29, 2020 08:35
@peterhoeg peterhoeg mentioned this pull request Aug 23, 2020
Merged
10 tasks
@oxalica oxalica mentioned this pull request Feb 22, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Ma27 @ryantm