Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cedille: fix hash #61028

Merged
merged 1 commit into from May 7, 2019
Merged

cedille: fix hash #61028

merged 1 commit into from May 7, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented May 6, 2019

Motivation for this change

Cedille retagged v.1.1.1 https://github.com/cedille/cedille/releases/tag/v1.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 01b99a6 into NixOS:master May 7, 2019
@JohnAZoidberg
Copy link
Member

Why does "fixHash" change so much? Has the content of the release changed so that we can drop a dependency and a patch? Or do you just not want to build the docs anymore?

@marsam
Copy link
Contributor Author

marsam commented May 7, 2019

docs/info/cedille-info-main.info is part of the repository, but the texinfo patch required us to regenerate it.
Since the new tag already includes the patch, and updated info, we can drop the docs generation.

@JohnAZoidberg
Copy link
Member

Alright, thanks for the explanation :)

@marsam marsam deleted the update-cedille branch May 31, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @JohnAZoidberg @FRidh