[Gecko Bug 1548935] enable wpt 'track-add-remove-cue.html'. #16704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can't get corresponding cue, `getCueById()` will return `null`, not empty object. Therefore, we should use `assert_equals` instead. Differential Revision: https://phabricator.services.mozilla.com/D29888 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548935 gecko-commit: f7adce9bf91ca23f8137bb4cf9cf5630b5f75613 gecko-integration-branch: autoland gecko-reviewers: jya
wpt-pr-bot
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't get corresponding cue,
getCueById()will returnnull, not empty object. Therefore, we should useassert_equalsinstead.Differential Revision: https://phabricator.services.mozilla.com/D29888
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1548935
gecko-commit: f7adce9bf91ca23f8137bb4cf9cf5630b5f75613
gecko-integration-branch: autoland
gecko-reviewers: jya