Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qscintilla: fix dylib names on Darwin #61056

Merged
merged 1 commit into from May 7, 2019
Merged

qscintilla: fix dylib names on Darwin #61056

merged 1 commit into from May 7, 2019

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented May 6, 2019 •
edited

Motivation for this change

On Darwin dylibs are intended to have their install names set to their absolute path. Without an absolute path, applications using these libraries will have invalid references embedded, and will be unable to locate the libraries at runtime.

Before

$ otool -D $(nix-build channel:nixos-unstable -A qscintilla)/lib/libqscintilla2.dylib | tail -n 1
libqscintilla2.12.dylib

After

$ otool -D $(nix-build . -A qscintilla)/lib/libqscintilla2.dylib | tail -n 1
/nix/store/n72ds0cqcnpkq9066lxjas2k814j4i79-qscintilla-qt4-2.9.4/lib/libqscintilla2.12.0.2.dylib
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 6, 2019
@thefloweringash
qscintilla: fix dylib names on Darwin
f045196 
On Darwin dylibs are intended to have their install names set to their
absolute path. Without an absolute path, applications using these
libraries will have invalid references embedded, and will be unable to
locate the libraries at runtime.
@ofborg ofborg bot requested a review from peterhoeg May 6, 2019 19:20
@FRidh FRidh merged commit 1d754bb into NixOS:master May 7, 2019
@thefloweringash thefloweringash deleted the qscintilla-dylib-name branch May 7, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thefloweringash @FRidh