Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfstools: add netpbm support (fix #60841) #61083

Merged
merged 2 commits into from Nov 2, 2019
Merged

Conversation

juliendehos
Copy link
Contributor

Motivation for this change

fix #60841

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented May 12, 2019

Builds for me, non-nixos linux x86_64.

Again, works under macos 10.13 with the changes mentioned in the other thread #61050 (comment), but you'll also have to change the references to "*.so*" in this PR to "*.${stdenv.hostPlatform.extensions.sharedLibrary}*".

@juliendehos
Copy link
Contributor Author

Fixed. Thanks.

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61083 1

1 package were build:
  • pfstools

$ ./results/pfstools/bin/pfsindcraw -h

Read an image in a camera RAW file format supported by
DCRAW and write pfs stream to the standard output as
if read from 16bit ppm file (no gamma correction,
white balance from camera if available).

Usage: pfsindcraw <file> [<file>...]

See the man page for more information.

@c0bw3b c0bw3b merged commit 41778dd into NixOS:master Nov 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 3, 2020
@juliendehos juliendehos deleted the pfstools branch March 25, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pfstools cannot import pictures in RAW format
3 participants