Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static: set default_library flag for meson in makeStaticLibrary #61169

Merged
merged 1 commit into from May 18, 2019

Conversation

matthewbauer
Copy link
Member

Adds support for building static libraries with meson.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adds support for building static libraries with meson.
@FRidh
Copy link
Member

FRidh commented May 14, 2019

Could you rebase this?

@matthewbauer matthewbauer changed the base branch from staging to master May 18, 2019 20:00
@matthewbauer matthewbauer changed the base branch from master to staging May 18, 2019 20:00
@matthewbauer matthewbauer merged commit 5ba6339 into NixOS:staging May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants