release-cross.nix changes/fixes #61168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer provided
We don’t have android sdk available for aarch64, so this error happens a lot. Adding some context on what is going on makes this clearer.
mesaPlatforms can be used in the platforms attr.
valgrind-light doesn’t appear to work correctly on aarch32. It’s also not a required dependency on mesa, so in the future we may be able to disable it for other platforms
causes on evaluation error on macOS otherwise
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Ericson2314
approved these changes
May 9, 2019
| , libglvnd | ||
| , enableRadv ? true | ||
| , galliumDrivers ? null | ||
| , driDrivers ? null | ||
| , vulkanDrivers ? null | ||
| , eglPlatforms ? [ "x11" ] ++ lib.optionals stdenv.isLinux [ "wayland" "drm" ] | ||
| , OpenGL, Xplugin | ||
| , withValgrind ? stdenv.hostPlatform.isLinux && !stdenv.hostPlatform.isAarch32, valgrind-light |
There was a problem hiding this comment.
In which cases do we default the package to null when it's possible to disable via an option?
You didn't but the enableRadv option does.
There was a problem hiding this comment.
I prefer to use with* flags as they are more obvious. I guess we can always do something like withValgrind ? valgrind != null, but it's a little awkward to go the other way with valgrind ? (if withValgrind then null else ?)
ofborg
bot
added
6.topic: haskell
6.topic: nixos
6.topic: python
6.topic: ruby
6.topic: stdenv
|
This PR is conflicting |
ofborg
bot
removed
6.topic: TeX
ofborg
bot
removed
6.topic: python
6.topic: ruby
6.topic: stdenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for the Hydra jobset that builds cross toolchains:
https://hydra.nixos.org/jobset/nixpkgs/cross-trunk
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)