Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: sed from gnused, not coreutils! fix bad path #60903

Merged
merged 1 commit into from May 8, 2019
Merged

networkmanager: sed from gnused, not coreutils! fix bad path #60903

merged 1 commit into from May 8, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 4, 2019

Motivation for this change

Eep!
Not sure how likely this is to be causing folks problems
but definitely should be fixed!

Don't we check udev rules for valid paths?
Maybe we can add a check for this sort of thing,
although TBH really hope there are no other instances.. !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request May 4, 2019
Closed
10 tasks
@jtojnar
Copy link
Contributor

jtojnar commented May 4, 2019

Don't we check udev rules for valid paths?
Maybe we can add a check for this sort of thing,

This is particularly difficult one since the invalid path is inside a string.

I actually prefer passing the full path to substituteAll, that could be more conducive to linters.

@samueldr samueldr added the 9.needs: port to stable A PR needs a backport to the stable release. label May 4, 2019
@samueldr
Copy link
Member

samueldr commented May 4, 2019

Considering the change was made in December, this means this issue is in 19.03. Unless this fix would further break something, this will need to be backported I think. Right?

@dtzWill
Copy link
Member Author

dtzWill commented May 8, 2019

Yes, this seems good to backport-- depending on build impact, maybe to the appropriate -staging?

@dtzWill dtzWill merged commit 666bcbe into NixOS:staging May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obadz obadz Awaiting requested review from obadz

@rickynils rickynils Awaiting requested review from rickynils

@Phreedom Phreedom Awaiting requested review from Phreedom

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @jtojnar @samueldr