Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgbds: 0.2.4 -> 0.3.8 #61091

Merged
merged 1 commit into from May 7, 2019
Merged

rgbds: 0.2.4 -> 0.3.8 #61091

merged 1 commit into from May 7, 2019

Conversation

lfont
Copy link
Contributor

@lfont lfont commented May 7, 2019

Motivation for this change
  • Switch to the new GitHub organization.
  • Updated to the latest published version.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rgbds: 0.2.4 -> 0.3.8
8ceb9bf 
- Switch to the new GitHub organization.
- Updated to the latest published version.
@ofborg ofborg bot requested a review from matthewbauer May 7, 2019 15:59
@matthewbauer
Copy link
Member

Thanks! This looks good to me.

@GrahamcOfBorg build rgbds

@Lassulus
Copy link
Member

Lassulus commented May 7, 2019

well it builds, I don't have stuff to test it with though.

@Lassulus Lassulus merged commit 05d6273 into NixOS:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lfont @matthewbauer @Lassulus @Janik-Haag