Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.seabreeze: init at 0.6.0 #61047

Closed
wants to merge 1 commit into from
Closed

python3Packages.seabreeze: init at 0.6.0 #61047

wants to merge 1 commit into from

Conversation

sjmackenzie
Copy link
Contributor

Motivation for this change

Need to interface with a spectrometer

Things done

added a python package

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sjmackenzie sjmackenzie requested a review from FRidh as a code owner May 6, 2019 12:08
@sjmackenzie sjmackenzie force-pushed the seabreeze branch 2 times, most recently from 0e157ba to 69efe0d Compare May 6, 2019 14:42
@sjmackenzie
Copy link
Contributor Author

requested changes completed

@sjmackenzie
Copy link
Contributor Author

requested changes completed

@worldofpeace worldofpeace changed the title python3Packages.seabreeze: init at 60569e python3Packages.seabreeze: init at 0.6.0 May 8, 2019
@worldofpeace
Copy link
Contributor

pushed to master in b0315ac

Thanks for contributing.

@sjmackenzie sjmackenzie deleted the seabreeze branch May 9, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjmackenzie @worldofpeace @JohnAZoidberg