Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_testing_bcachefs,bcachefs-tools: 2019-04-04 -> 2019-05-08 #61171

Merged
merged 2 commits into from May 17, 2019
Merged

linux_testing_bcachefs,bcachefs-tools: 2019-04-04 -> 2019-05-08 #61171

merged 2 commits into from May 17, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 9, 2019 •
edited

This is either terribly broken or working fine.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu marked this pull request as ready for review May 11, 2019 14:34
@joachifm
Copy link
Contributor

This is either terribly broken or working fine.

What does "this" refer to here? The version in the PR or the software overall?

@eadwu
Copy link
Member Author

eadwu commented May 14, 2019

The version, anyway been using it fine for the 6 days I've had it. The reason for the statement was due to the issues that popped up during the last revision which resulted in an unrecoverable corrupted filesystem in my case.

@joachifm joachifm merged commit bfadef5 into NixOS:master May 17, 2019
@joachifm
Copy link
Contributor

Alright. Thank you. I expect people running this also understand the risks.

@danielfullmer danielfullmer mentioned this pull request May 21, 2019
Closed
@eadwu eadwu deleted the bcachefs/update-2 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @joachifm