Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxinator: 0.13.0 -> 1.1.0 #60858

Merged
merged 1 commit into from May 9, 2019
Merged

tmuxinator: 0.13.0 -> 1.1.0 #60858

merged 1 commit into from May 9, 2019

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented May 3, 2019

Motivation for this change

Tmuxinator was out of date, and 1.1.0 brings compatibility with Tmux 2.9 which is now out on nixpkgs unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JohnAZoidberg
JohnAZoidberg approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine.
I've never used it before but tmuxinator new foo and tmuxinator start foo work fine.

@marsam marsam merged commit cfb9661 into NixOS:master May 9, 2019
@ejpcmac ejpcmac deleted the update-tmuxinator branch July 10, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeyroux apeyroux apeyroux approved these changes

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ejpcmac @apeyroux @JohnAZoidberg @marsam