jo: 1.1 -> 1.2 #61040
Merged
jo: 1.1 -> 1.2 #61040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build jo |
|
Looks fine to me, I built and tested the result and didn't encounter any issues 👍 |
|
It has a small test suite that can be enabled by adding Also |
Lassulus
reviewed
May 7, 2019
| @@ -1,15 +1,14 @@ | |||
| {stdenv, fetchFromGitHub, autoreconfHook}: | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "jo-${version}"; | |||
| version = "1.1"; | |||
| name = "jo-${version}"; | |||
There was a problem hiding this comment.
hmm, I'm no big fan of this alignment.
- It wastes more space
- If we, for example, change name to pname, we either generate diff noise or leave it inconsistent.
There was a problem hiding this comment.
I will change it to pname right away and fix alignment.
tomberek
approved these changes
May 7, 2019
marsam
reviewed
May 8, 2019
| sha256="1gn9fa37mfb85dfjznyfgciibf142kp0gisc2l2pnz0zrakbvvy3"; | ||
| owner = "jpmens"; | ||
| repo = "jo"; | ||
| rev = "${version}"; |
There was a problem hiding this comment.
it's not necessary to interpolate version
Suggested change
| rev = "${version}"; | |
| rev = version; |
Lassulus
reviewed
May 8, 2019
| sha256="1gn9fa37mfb85dfjznyfgciibf142kp0gisc2l2pnz0zrakbvvy3"; | ||
| owner = "jpmens"; | ||
| repo = "jo"; | ||
| rev = version; |
The "src.rev" was changed because upstream tag does not have the "v" prefix for this version. A little bit of code formatting was done as well. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
Tested locally on NixOS and darwin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "src.rev" was changed because upstream tag does not have the "v"
prefix for this version.
A little bit of code formatting was done as well.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)