Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upower: 0.99.9 -> 0.99.10 #61174

Merged
merged 1 commit into from May 9, 2019
Merged

upower: 0.99.9 -> 0.99.10 #61174

merged 1 commit into from May 9, 2019

Conversation

worldofpeace
Copy link
Contributor

Using placeholder and drop the NIX_CFLAGS_LINK.

https://gitlab.freedesktop.org/upower/upower/blob/UPOWER_0_99_10/NEWS

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented May 9, 2019

LGTM, thanks! Scratching my head re:how we didn't pick up this release until now (apparently released 2019-02-02), but that's just a curiosity :).

Hopefully they cut a new release soon--or I suppose we could pick the 4 or so commits following this release, for dbus/systemd service touchups + hardening. Probably best to wait a bit :).

@worldofpeace
Copy link
Contributor Author

LGTM, thanks! Scratching my head re:how we didn't pick up this release until now (apparently released 2019-02-02), but that's just a curiosity :).

Hopefully they cut a new release soon--or I suppose we could pick the 4 or so commits following this release, for dbus/systemd service touchups + hardening. Probably best to wait a bit :).

Oh I already assumed you were thinking about this (it's a race against dtzWill-update 🤣 )

I think it's just good to just merge this now since it was bugfixes (I don't like things to sit), I expect them to cut a release for sure before 19.09.

@worldofpeace worldofpeace merged commit 974cbe2 into NixOS:master May 9, 2019
@worldofpeace worldofpeace deleted the bump-upower branch May 9, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @dtzWill