Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: Build with latest qt5 #61105

Closed
wants to merge 1 commit into from
Closed

teamviewer: Build with latest qt5 #61105

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented May 7, 2019 •
edited

Motivation for this change

See #33798

Seems to work fine for me though I haven't tested connecting to anyone as I don't use teamviewer myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jagajaga

@worldofpeace
Copy link
Contributor

worldofpeace commented May 7, 2019 •
edited

There was reports of segfaults with latest qt5 #53117
See also #54259 (comment).

So this should be tested by an actual user.

cc @Mic92 (guessing)

@adisbladis
Copy link
Member Author

Ping @jagajaga

@Ma27
Copy link
Member

Ma27 commented Aug 22, 2019

Would you mind having a look at #67244? This bumps teamviewer to the latest version and wraps QT properly. Also didn't encounter any issues with the new teamviewer version :)

@worldofpeace
Copy link
Contributor

Superseded by #67244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @worldofpeace @Ma27