awesome: use makeWrapper rather than wrapProgram #61060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using wrapProgram makes so that the generated "awesome" wrapper duplicates its command line options at every restart. As @psychon puts it: > AwesomeWM restarts via execvp(argv[0], argv). In NixOS, wrapProgram is used > to generate a wrapper around the real binary. wrapProgram calls makeWrapper > with --argv0 '$0'. I guess this is what makes awesomeWM run the wrapper again > on restart. Without this --argv0 awesomeWM would directly restart itself > instead of the wrapper, I think.
|
also backported in 49a9155 |
rasendubi
reviewed
May 7, 2019
| @@ -48,7 +48,10 @@ with luaPackages; stdenv.mkDerivation rec { | |||
| LUA_PATH = "${lgi}/share/lua/${lua.luaversion}/?.lua;;"; | |||
|
|
|||
| postInstall = '' | |||
| wrapProgram $out/bin/awesome \ | |||
| # Don't use wrapProgram or or the wrapper will duplicate the --search | |||
There was a problem hiding this comment.
Seen this too late, sorry. But I fixed it with the changes in #61161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Using wrapProgram makes so that the generated "awesome" wrapper duplicates its
command line options at every restart. This fixes #60229.
As @psychon puts it:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)