Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icr: 0.5.0 -> 0.6.0 #61156

Merged
merged 2 commits into from May 12, 2019
Merged

icr: 0.5.0 -> 0.6.0 #61156

merged 2 commits into from May 12, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 8, 2019

Motivation for this change

None other than fixing a failing build on Hydra
Changelog: https://github.com/crystal-community/icr/releases/tag/v0.6.0
cc @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented May 8, 2019

nox-review builds for me, non-nixos linux x86_64, but executing icr complains:

Can not find `crystal` command. Make sure you have crystal installed.

Surely this should be makeWrappered into the PATH rather than relying on the execution environment's crystal?

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 9, 2019

Only @peterhoeg could confirm but I guess it was done on purpose, to allow using icr with different crystal version, not just a fixed one.

@c0bw3b c0bw3b merged commit 3cdb2c3 into NixOS:master May 12, 2019
@c0bw3b c0bw3b deleted the pkg/icr branch May 12, 2019 13:28
@peterhoeg
Copy link
Member

Sorry about the late reply guys.

but I guess it was done on purpose, to allow using icr with different crystal version, not just a fixed one.

Indeed. Although an argument can of course also be made for having it work out of the box. I'll open a PR to remove the wrapper.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 15, 2019

Ah ok, no problem.
I saw your +1 on @risicle comment so I then assumed I was wrong.
But do cc me on your PR

tadeokondrak pushed a commit to tadeokondrak/nixpkgs that referenced this pull request May 17, 2019
* icr: 0.5.0 -> 0.6.0

* icr: ensure crystal is in PATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants