pythonPackages.worldengine: fix tests by moving nose to checkInputs #60998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also only perform nosetests in py<3.5
risicle
force-pushed
the
ris-worldengine-fix
branch
from
fddf77f
to
4a72ca1
Compare
|
@GrahamcOfBorg build python27Packages.worldengine python37Packages.worldengine |
|
Well gdal timeout on Darwin is unrelated, the build of |
c0bw3b
approved these changes
May 7, 2019
There was a problem hiding this comment.
Result of nix-review pr 60998 1
2 package were build:
- python27Packages.worldengine
- python37Packages.worldengine
$ ./results/python37Packages.worldengine/bin/worldengine --version
-------------------------------------------------------------------
Federico Tomassetti and Bret Curtis, 2011-2015
Worldengine - a world generator (v. 0.19.0)
worldengine <world_name> [operation] [options]
possible operations: world|plates|ancient_map|info|export
use -h to see options
-------------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a draft PR because it sits on top of a required fix forDone.purepng@ #60813, will rebase once that's merged.The tests are all actually
unittesttests, it seemsnoseis only necessary on python <3.5 where the naming of the test modules causesunittestitself not to be able to pick them up.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)