Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: add sonos component dependencies #60853

Closed
wants to merge 0 commits into from
Closed

home-assistant: add sonos component dependencies #60853

wants to merge 0 commits into from

Conversation

oneingan
Copy link
Contributor

@oneingan oneingan commented May 3, 2019

Motivation for this change

Add required python packages and binding them in the component-packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oneingan oneingan requested a review from FRidh as a code owner May 3, 2019 09:07
@oneingan oneingan mentioned this pull request May 3, 2019
Closed
@FRidh
Copy link
Member

FRidh commented May 4, 2019

cc @dotlambda

@FRidh
Copy link
Member

FRidh commented May 4, 2019

@GrahamcOfBorg build python2.pkgs.psonos python3.pkgs.sonos

dotlambda
dotlambda requested changes May 4, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make much sense to merge this before #60217 is merged. So I'll ask you to rebase once that's done.

pkgs/development/python-modules/pysonos/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonos/default.nix Outdated Show resolved Hide resolved
@oneingan oneingan mentioned this pull request May 4, 2019
Closed
@dotlambda dotlambda changed the base branch from master to staging May 7, 2019 12:57
dotlambda
dotlambda requested changes May 7, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update pysonos to 0.0.13 and re-run parse-requirements.py after rebasing on d280603.

@oneingan oneingan closed this May 8, 2019
dotlambda
dotlambda requested changes May 10, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits such that there's one called pythonPackages.pysonos: init at 0.0.13 and another one called home-assistant: run parse-requirements.py.

pkgs/development/python-modules/pysonos/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonos/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pysonos python3.pkgs.pysonos

@dotlambda dotlambda changed the base branch from staging to master May 20, 2019 11:09
@dotlambda dotlambda closed this May 20, 2019
@dotlambda
Copy link
Member

Sorry, I f**d up. Let's continue here: #61748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oneingan @FRidh @dotlambda