Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.datasette: init at 0.27 #61085

Merged
merged 9 commits into from May 8, 2019
Merged

pythonPackages.datasette: init at 0.27 #61085

merged 9 commits into from May 8, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented May 7, 2019

Motivation for this change

Inspired by pycon talk about web server for sqlite databases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner May 7, 2019 12:56
@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

@GrahamcOfBorg build python3Packages.datasette python3Packages.csvc-to-sqlite

@costrouc costrouc force-pushed the python-datasette-init branch 4 times, most recently from 464e722 to af35ad9 Compare May 7, 2019 16:06
@costrouc
Copy link
Member Author

costrouc commented May 7, 2019

nix review passes

Result of nix-review pr 61085 1

12 package were build:
  • csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • datasette (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.uvloop (python37Packages.csvs-to-sqlite ,python37Packages.datasette)

@costrouc costrouc force-pushed the python-datasette-init branch 2 times, most recently from dfbeac6 to 35d3830 Compare May 8, 2019 11:42
@costrouc
Copy link
Member Author

costrouc commented May 8, 2019

Result of nix-review pr 61085 1

12 package were build:
  • csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • datasette (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.uvloop (python37Packages.csvs-to-sqlite ,python37Packages.datasette)

@risicle
Copy link
Contributor

risicle commented May 8, 2019

Would you be able to shuffle the order of the commits so that the dependent packages come after their dependencies? This way there aren't any "broken" intermediary commit states, which makes bisecting nicer for everyone.

@risicle
Copy link
Contributor

risicle commented May 8, 2019

(nox-review builds for me, executables basically work, non-nixos linux x86_64)

@marsam marsam merged commit 7c7ccd5 into NixOS:master May 8, 2019
@marsam
Copy link
Contributor

marsam commented May 8, 2019

Sorry for the delay, looks good. Thanks @costrouc, @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @risicle @marsam