This repository was archived by the owner on Apr 12, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 104
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2df17ecf1b74
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3e7300cf0498
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 2 files changed
- 3 contributors
Commits on May 6, 2019
-
awesome: refactor LUA_PATH env var and don't expose it at runtime
This commit partly reinstates changes from 5465d6f that had been somehow reverted in 17d3eb2. Also, a comment has been added in the hope that future changes won't do the same. Additionally, refactor the LUA_PATH env var to ensure that the internal lgi lua files can't be required explicitly and to avoid possible name clashes (this fixes issue #60232). Finally, rather than using prepending `?.lua` append `;;` to LUA_PATH. Quoting @psychon: > This is interpreted by Lua as "add the default search path here" (which does > indeed contain ?.lua, but also contains more). Testing done: - Build with `nix-build -I /path/to/repo -A awesome` - Start an X session with xterm only - Start xephyr, e.g. `Xephyr :1 -name xephyr -screen 512x384 -ac -br -noreset &` - Run awesome like `DISPLAY=:1.0 ./result/bin/awesome`. Additionally, add `--search` options to expose lua modules that have a name clash with lgi's internal ones (see #60232 for more details) and `require` them in `rc.lua` to prove that they are loaded correctly
Configuration menu - View commit details
-
Copy full SHA for 8b5ec80 - Browse repository at this point
Copy the full SHA 8b5ec80View commit details
Commits on May 7, 2019
-
awesome: use makeWrapper rather than wrapProgram
Using wrapProgram makes so that the generated "awesome" wrapper duplicates its command line options at every restart. As @psychon puts it: > AwesomeWM restarts via execvp(argv[0], argv). In NixOS, wrapProgram is used > to generate a wrapper around the real binary. wrapProgram calls makeWrapper > with --argv0 '$0'. I guess this is what makes awesomeWM run the wrapper again > on restart. Without this --argv0 awesomeWM would directly restart itself > instead of the wrapper, I think. (cherry picked from commit 88f84c0)
Configuration menu - View commit details
-
Copy full SHA for 49a9155 - Browse repository at this point
Copy the full SHA 49a9155View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dcbd44 - Browse repository at this point
Copy the full SHA 2dcbd44View commit details -
Merge pull request #61043 from stefano-m/release-19.03
awesome: refactor LUA_PATH env var and don't expose it at runtime (19.03 branch)
Configuration menu - View commit details
-
Copy full SHA for 3e7300c - Browse repository at this point
Copy the full SHA 3e7300cView commit details
There are no files selected for viewing