Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doge: init at 3.5.0 #61065

Merged
merged 1 commit into from May 7, 2019
Merged

doge: init at 3.5.0 #61065

merged 1 commit into from May 7, 2019

Conversation

Gonzih
Copy link
Contributor

@Gonzih Gonzih commented May 7, 2019 •
edited

Motivation for this change

Adding the most important tool without which workflow in terminal is almost impossible.

The doge utility.

doge

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu
etu reviewed May 7, 2019
View reviewed changes
pkgs/misc/doge/default.nix Outdated Show resolved Hide resolved
etu
etu reviewed May 7, 2019
View reviewed changes
pkgs/misc/doge/default.nix Outdated Show resolved Hide resolved
etu
etu reviewed May 7, 2019
View reviewed changes
pkgs/misc/doge/default.nix Outdated Show resolved Hide resolved
@Gonzih
Copy link
Contributor Author

Gonzih commented May 7, 2019

@etu addressed feedback, thanks for looking in to this!

etu
etu reviewed May 7, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
etu
etu reviewed May 7, 2019
View reviewed changes
pkgs/misc/doge/default.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor

etu commented May 7, 2019

With the following diff this package works perfectly fine:

diff --git a/pkgs/misc/doge/default.nix b/pkgs/misc/doge/default.nix
index 0d34d147285..35ec792ae11 100644
--- a/pkgs/misc/doge/default.nix
+++ b/pkgs/misc/doge/default.nix
@@ -1,22 +1,15 @@
-{ lib
-, buildPythonPackage
-, fetchPypi
-, python3Packages
-}:
+{ stdenv, python3Packages }:
 
-with python3Packages;
-buildPythonPackage rec {
+python3Packages.buildPythonPackage rec {
   pname = "doge";
   version = "3.5.0";
 
-  src = fetchPypi {
+  src = python3Packages.fetchPypi {
     inherit pname version;
     sha256 = "0lwdl06lbpnaqqjk8ap9dsags3bzma30z17v0zc7spng1gz8m6xj";
   };
 
-  doCheck = true;
-
-  meta = with lib; {
+  meta = with stdenv.lib; {
     homepage = https://github.com/thiderman/doge;
     description = "wow very terminal doge";
     license = licenses.mit;

@Gonzih
Copy link
Contributor Author

Gonzih commented May 7, 2019

@etu applied your patch

@etu
Copy link
Contributor

etu commented May 7, 2019

@GrahamcOfBorg build doge

@Gonzih Thanks :-)

@Gonzih
Copy link
Contributor Author

Gonzih commented May 7, 2019

@etu no no, thank you for your time and patience :)

@Gonzih Gonzih changed the title doge: Init at 3.5.0 doge: init at 3.5.0 May 7, 2019
@Lassulus
Copy link
Member

Lassulus commented May 7, 2019

tested it with nix-review and was overwhelmed by the usefulness.

@Lassulus Lassulus merged commit 8ee40cc into NixOS:master May 7, 2019
@Gonzih Gonzih deleted the gonzih/doge branch May 7, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gonzih @etu @Lassulus