Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 0.24.0 -> 0.25.1 #61097

Closed
wants to merge 3 commits into from
Closed

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented May 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit changed the title bazel: 0.24.0 -> 0.25.0 bazel: 0.24.0 -> 0.25.1 May 7, 2019
@kalbasit
Copy link
Member Author

kalbasit commented May 8, 2019

@Profpatsch For some reason native.bazel_version is not set, and the rule_nodejs rules are failing because of it. This happens at the installPhase. I'm stuck on it, thoughts?

DEBUG: /build/bazel_zbwenLNJ/out/external/build_bazel_rules_nodejs/internal/common/check_bazel_version.bzl:49:5:
Current Bazel is not a release version, cannot check for compatibility.
DEBUG: /build/bazel_zbwenLNJ/out/external/build_bazel_rules_nodejs/internal/common/check_bazel_version.bzl:51:5: Make sure that you are running at least Bazel 0.17.1.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel

@Profpatsch
Copy link
Member

Profpatsch commented May 9, 2019

The problem here is that bazelbuild/bazel@6f52fca adds a new remote dep, skydoc. That is pulled in by the tests we run after the build, but it’s not locally available, so bazel tries to download it.

I’m taking a shot at debugging why the tests pull in the skydoc repository, but maybe it is best to disable the tests for now.

Update: I don’t get the same error you are getting, my build runs fine (once I disable the postInstall tests).

@Profpatsch
Copy link
Member

It could also have something to do with the bazel_java_tools artifact being out of date.
Sadly, @groodt didn’t add a comment where he got the link to the tarball from when he added the artifact, and I have not the slightest idea where to search for it …

@groodt
Copy link
Contributor

groodt commented May 9, 2019

Sadly, @groodt didn’t add a comment where he got the link to the tarball from when he added the artifact, and I have not the slightest idea where to search for it …

During postInstall, it attempts to run some test builds using the WORKSPACE. For 0.24.1 which I helped with, it's here:
https://github.com/bazelbuild/bazel/blob/f092ec388a4b58788285b928c86f0f81561d4be4/WORKSPACE#L120

@groodt
Copy link
Contributor

groodt commented May 9, 2019

For 0.25.1, looks like the WORKSPACE is more comprehensive and loading a bunch of rules:

load("@io_bazel_skydoc//:setup.bzl", "skydoc_repositories")

skydoc_repositories()

load("@io_bazel_rules_sass//:package.bzl", "rules_sass_dependencies")

rules_sass_dependencies()

load("@build_bazel_rules_nodejs//:defs.bzl", "node_repositories")

node_repositories()

load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories")

All of those will hydrate files from the internet.

@Profpatsch Profpatsch mentioned this pull request Jun 3, 2019
10 tasks
@kalbasit
Copy link
Member Author

kalbasit commented Jun 6, 2019

closing this in favor of #62336

@kalbasit kalbasit closed this Jun 6, 2019
@kalbasit kalbasit deleted the nixpkgs_update-bazel branch June 6, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants