Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstree: remove and alias to psmisc #60994

Merged
merged 1 commit into from May 7, 2019
Merged

pstree: remove and alias to psmisc #60994

merged 1 commit into from May 7, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 5, 2019

Motivation for this change

Former pstree is abandonware at this point in time (the first src url is gone for example).
And the maintained package psmisc provides a pstree tool with more options

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds runs and functions on Ubuntu.

@Lassulus Lassulus merged commit 4f8bf68 into NixOS:master May 7, 2019
@c0bw3b c0bw3b deleted the pkg/pstree branch May 7, 2019 18:12
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
@lilyball lilyball mentioned this pull request May 19, 2019
Closed
@c0bw3b c0bw3b removed this from Done in Picking up garbage May 20, 2019
@c0bw3b c0bw3b mentioned this pull request May 20, 2019
Merged
10 tasks
vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request May 20, 2019
@c0bw3b
Merge pull request NixOS#61763 from c0bw3b/pkg/pstree-classic
650a295 
pstree: re-init at 2.39 (reverts NixOS#60994)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @tomberek @Lassulus