Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] firefox: 66.0.4 -> 66.0.5, firefox-bin: 66.0.4 -> 66.0.5, firefox-beta-bin: 67.0b7 -> 670b18 #61132

Merged
merged 3 commits into from May 8, 2019
Merged

[19.03] firefox: 66.0.4 -> 66.0.5, firefox-bin: 66.0.4 -> 66.0.5, firefox-beta-bin: 67.0b7 -> 670b18 #61132

merged 3 commits into from May 8, 2019

Conversation

andir
Copy link
Member

@andir andir commented May 8, 2019 •
edited

Motivation for this change

For the firefox attribute the changelog can be seen at https://blog.mozilla.org/addons/2019/05/04/update-regarding-add-ons-in-firefox/comment-page-5 It is yet another fixup of the certificate issue that started last week.

Haven't tested yet since the build hasn't finished locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

andir added 3 commits May 8, 2019 11:34
@andir
firefox-beta-bin: 67.0b7 -> 670b18
516bfe4 
(cherry picked from commit c771c1dcc2bafc6854f68036581d30227c364d9c)
@andir
firefox-bin: 66.0.4 -> 66.0.5
d0fdae6 
Signed-off-by: Andreas Rammhold <andreas@rammhold.de>
@andir
firefox: 66.0.4 -> 66.0.5
ba383c7 
(cherry picked from commit 67201d0de6e4bd695330ba0e0602be1eca83d5ec)
@ofborg ofborg bot requested a review from edolstra May 8, 2019 10:00
@edolstra edolstra merged commit 16ecfeb into NixOS:release-19.03 May 8, 2019
@andir andir deleted the 19.03/firefox branch May 8, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @edolstra