Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: 415.27 -> 418.43 - backport from master #61140

Merged
merged 2 commits into from May 11, 2019
Merged

nvidia_x11: 415.27 -> 418.43 - backport from master #61140

merged 2 commits into from May 11, 2019

Conversation

yorickvP
Copy link
Contributor

@yorickvP yorickvP commented May 8, 2019

Motivation for this change

Fixes #57062 on 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build linuxPackages_latest.nvidiaPackages.stable linuxPackages_5_0.nvidiaPackages.stable linuxPackages.nvidiaPackages.stable linuxPackages.nvidia_x11
cc @eadwu

eadwu added 2 commits May 8, 2019 14:14
@eadwu @yorickvP
nvidia_x11: 415.27 -> 418.43
811a520 
(cherry picked from commit 48e66e5)
@eadwu @yorickvP
nvidia_x11: 418.43 -> 418.56
063c339 
(cherry picked from commit 928d51a)
@yorickvP
Copy link
Contributor Author

yorickvP commented May 8, 2019

@GrahamcOfBorg build linuxPackages_latest.nvidiaPackages.stable linuxPackages_5_0.nvidiaPackages.stable linuxPackages.nvidiaPackages.stable linuxPackages.nvidia_x11

@yorickvP
Copy link
Contributor Author

yorickvP commented May 8, 2019

(cc: @Mic92)

@eadwu
Copy link
Member

eadwu commented May 8, 2019 •
edited

Looks fine, though 418.74 was released recently, so it might be better to create a PR for 418.74 before cherry-picking it here to also backport.

See #61164.

@adamtulinius
Copy link
Member

+1, I can confirm the original issue, and have been building 19.03 from my own branch based on 19.03 with these exact two commits cherry-picked on top for quite some time, without issues.

@veprbl
Copy link
Member

veprbl commented May 11, 2019

@GrahamcOfBorg eval

@veprbl veprbl merged commit c2570ef into NixOS:release-19.03 May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yorickvP @eadwu @adamtulinius @veprbl