Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv: fix missing dependency issue (#61027) #61044

Merged
merged 1 commit into from May 7, 2019
Merged

pipenv: fix missing dependency issue (#61027) #61044

merged 1 commit into from May 7, 2019

Conversation

greydot
Copy link
Contributor

@greydot greydot commented May 6, 2019

Motivation for this change

Fix #61027

Things done

Added missing package to propagatedBuildInputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@greydot
Copy link
Contributor Author

greydot commented May 6, 2019

Ping @berdario @dgarzon

@marsam
Copy link
Contributor

marsam commented May 7, 2019

@GrahamcOfBorg build pipenv

@marsam marsam merged commit bdbd5f6 into NixOS:master May 7, 2019
@marsam
Copy link
Contributor

marsam commented May 7, 2019

Tested locally on NixOS and darwin
@greydot, @berdario thanks for looking into this

@greydot greydot deleted the fix-pipenv-deps branch May 15, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berdario berdario berdario approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to install pipenv on unstable
3 participants
@greydot @marsam @berdario