Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskell: 1.4.2 -> 1.4.3 #61126

Merged
merged 2 commits into from May 15, 2019
Merged

taskell: 1.4.2 -> 1.4.3 #61126

merged 2 commits into from May 15, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Followup for #60363

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (centos)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor Author

@dtzWill and @BenBals here we go.

@matthiasbeyer
taskell: 1.4.2 -> 1.4.3
09c0b89 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@BenBals
Copy link
Contributor

BenBals commented May 8, 2019

Thanks for the mention.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Linux nixos-beb 4.19.37 Compile glibc without -fstack-protector. #1-NixOS SMP Sat Apr 27 07:36:41 UTC 2019 x86_64 GNU/Linux
  • executables tested on Linux nixos-beb 4.19.37 Compile glibc without -fstack-protector. #1-NixOS SMP Sat Apr 27 07:36:41 UTC 2019 x86_64 GNU/Linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

Is meta.maintainers unset or am I just missing it?

@matthiasbeyer
Copy link
Contributor Author

Hmh all meta info is missing. Will fix this ... Maybe tomorrow tho

@matthiasbeyer
Copy link
Contributor Author

@GrahamcOfBorg build taskell

@marsam marsam merged commit 1d9aaf6 into NixOS:master May 15, 2019
@marsam
Copy link
Contributor

marsam commented May 15, 2019

I fixed a minor issue in the last commit, I hope you don't mind
Thanks!

@matthiasbeyer matthiasbeyer deleted the update-taskell branch May 15, 2019 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @BenBals @marsam