Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memtest86+: update / remove legacy memtest86 #61147

Merged
merged 2 commits into from May 17, 2019
Merged

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 8, 2019

Motivation for this change

Legacy memtest86 was broken since 16.09 and we are already using memtest86+ from coreboot through boot.loader.grub.memtest86.enable.
Coreboot marked a more recent commit as stable and called it 5.01 coreboot 002 (we were actually shipping 5.01 coreboot 001 up to now). I tested building and running it in a x64 NixOS VM without issue.

This memtest is intended for BIOS-systems only.
The newer memtest86-efi from PassMark will be available for UEFI systems (see #60967).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b added 2 commits May 8, 2019 17:01
Latest stable stag of the coreboot fork
Legacy memtest86 was broken since NixOS 16.09
+ we've already been using memtest86+ fork
through 'boot.loader.grub.memtest86.enable'
@c0bw3b
Copy link
Contributor Author

c0bw3b commented May 17, 2019

@GrahamcOfBorg build memtest86plus

@c0bw3b c0bw3b merged commit d59e63f into NixOS:master May 17, 2019
Picking up garbage automation moved this from To do to Done May 17, 2019
@c0bw3b c0bw3b deleted the pkg/memtest branch May 17, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant