Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EnableTextMode Dwarf Fortress for playing CLI #61058

Merged
merged 1 commit into from May 7, 2019
Merged

Added EnableTextMode Dwarf Fortress for playing CLI #61058

merged 1 commit into from May 7, 2019

Conversation

TrevtheForthDev
Copy link
Contributor

@TrevtheForthDev TrevtheForthDev commented May 6, 2019

Motivation for this change

Wanted to play Dwarf Fortress in CLI so I could SSH on my phone and play it.

Things done
  • [*] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [* ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [* ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [*] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [*] Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

Lassulus commented May 7, 2019

oh cool, I ran dwarf fortress in my terminal, sadly it didn't get resize events, but that's not a problem of this PR.

@Lassulus Lassulus merged commit 3fcd66c into NixOS:master May 7, 2019
@@ -58,6 +59,10 @@ let
'' + lib.optionalString enableTWBT ''
substituteInPlace $out/data/init/init.txt \
--replace '[PRINT_MODE:2D]' '[PRINT_MODE:TWBT]'
'' +
lib.optionalString enableTextMode ''
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be more readable to merge these two lines (62 and 63). I would have it read something like:
'' + lib.optionalString enableTextMode ''.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do that if I add or edit anything again. Text mode was a bit important for me as I can SSH into it from my phone now.
"Pffft. Linux, you say? Grow a beard and enable the ncurses console mode, you GUI ne'er-do-well.

cp init.txt backup.txt && sed 's/PRINT_MODE:.*\]/PRINT_MODE:TEXT\]/' backup.txt > init.txt

I tell you true: mortal jaws slack — and maidens' underthings do drop — to see a proper /dev/tty1 fortress, fully realized and wrapped in visual mystery. Stonesense... that will earn you naught but the scorn of men.
"
(Warning, this doesn't work on NixOS as init.txt is read only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants