Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cartopy: fix tests for python2.7 using xvfb #60948

Merged
merged 1 commit into from May 7, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 4, 2019

Motivation for this change

Draft PR because this sits on top of #60936

Python 2.7's tk is over-eager in trying to open an x display, so run the tests in xvfb. xvfb is quite a heavy dependency (albeit only a build-time one), so ensure this is only used when needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python 2.7's tk is over-eager in trying to open an x display,
so run it in xvfb. xvfb is quite a heavy dependency (albeit only
a build-time one), so ensure this is only used when needed.
@risicle risicle marked this pull request as ready for review May 6, 2019 18:44
@risicle risicle requested a review from FRidh as a code owner May 6, 2019 18:44
@worldofpeace
Copy link
Contributor

worldofpeace commented May 7, 2019

@GrahamcOfBorg build pythonPackages.cartopy

@worldofpeace worldofpeace merged commit d61543a into NixOS:master May 7, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented May 7, 2019

Thanks for taking care of the python build failures @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants