Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7095449a5724
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 52ac2d9dccbe
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 8, 2019

  1. linuxPackages.perf: add libopcodes as a buildInput 

    Newer versions of perf in Linux 5.1+ support disassembling and
annotating eBPF programs inside the kernel. In order to do this, it uses
libbfd's support for bpf disassembly. There are two parts: libopcodes
and libbfd.

The 'perf' build system seems to expect libopcodes/libbfd to go "hand in
hand" -- always together, if one or the other is installed. If the build
system detects libbfd is available, then an import of <dis-asm.h> is
performed, but this fails since it wasn't in the buildInput. Fixing this
should be an easy, backwards-compatible change.

Fixes #60891, allowing linuxPackages_testing.perf to build again
(currently kernel version 5.1.0-rc7).

Signed-off-by: Austin Seipp <aseipp@pobox.com>
(cherry picked from commit c8cb015)
    @thoughtpolice @lheckemann
    thoughtpolice authored and lheckemann committed May 8, 2019
    Copy the full SHA
    52ac2d9 View commit details
    Browse the repository at this point in the history